Skip to content

Resolve warnings found in NBitcoin #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quantumagi merged 1 commit into from
Nov 17, 2021
Merged

Resolve warnings found in NBitcoin #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/NBitcoin/BIP39/Mnemonic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public Mnemonic(string mnemonic, Wordlist wordlist = null)
wordlist = Wordlist.AutoDetect(mnemonic) ?? Wordlist.English;

string[] words = mnemonic.Split((char[])null, StringSplitOptions.RemoveEmptyEntries);
_Mnemonic = string.Join(wordlist.Space.ToString(), words);
this._Mnemonic = string.Join(wordlist.Space.ToString(), words);

//if the sentence is not at least 12 characters or cleanly divisible by 3, it is bad!
if (!CorrectWordCount(words.Length))
Expand All @@ -54,7 +54,7 @@ public Mnemonic(Wordlist wordList, byte[] entropy = null)

int i = Array.IndexOf(entArray, entropy.Length * 8);
if(i == -1)
throw new ArgumentException("The length for entropy should be : " + String.Join(",", entArray), "entropy");
throw new ArgumentException("The length for entropy should be : " + string.Join(",", entArray), "entropy");

int cs = csArray[i];
byte[] checksum = Hashes.SHA256(entropy);
Expand Down Expand Up @@ -200,10 +200,10 @@ public ExtKey DeriveExtKey(string passphrase = null)
return new ExtKey(DeriveSeed(passphrase));
}

private static Byte[] Concat(Byte[] source1, Byte[] source2)
private static byte[] Concat(byte[] source1, byte[] source2)
{
//Most efficient way to merge two arrays this according to http://stackoverflow.com/questions/415291/best-way-to-combine-two-or-more-byte-arrays-in-c-sharp
var buffer = new Byte[source1.Length + source2.Length];
var buffer = new byte[source1.Length + source2.Length];
Buffer.BlockCopy(source1, 0, buffer, 0, source1.Length);
Buffer.BlockCopy(source2, 0, buffer, source1.Length, source2.Length);

Expand Down
2 changes: 1 addition & 1 deletion src/NBitcoin/Money.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ public string Format(string format, object arg, IFormatProvider formatProvider)
i++;
}
char unit = format[i];
var unitToUseInCalc = MoneyUnit.BTC;
MoneyUnit unitToUseInCalc = MoneyUnit.BTC;
switch (unit)
{
case 'B':
Expand Down
2 changes: 1 addition & 1 deletion src/NBitcoin/TransactionBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1584,7 +1584,7 @@ public int EstimateSize(Transaction tx, bool virtualSize)
int witSize = 0;
if (tx.HasWitness)
witSize += 2;
foreach (var txin in tx.Inputs.AsIndexedInputs())
foreach (IndexedTxIn txin in tx.Inputs.AsIndexedInputs())
{
ICoin coin = FindSignableCoin(txin) ?? FindCoin(txin.PrevOut);
if (coin == null)
Expand Down