[POA] Fix rewinding expired polls#769
Merged
fassadlr merged 9 commits intostratisproject:release/1.1.0.0from Nov 17, 2021
Merged
[POA] Fix rewinding expired polls#769fassadlr merged 9 commits intostratisproject:release/1.1.0.0from
fassadlr merged 9 commits intostratisproject:release/1.1.0.0from
Conversation
fassadlr
commented
Nov 16, 2021
|
|
||
| // Check if the current tip is before the poll expiry activation block, | ||
| // if so un-expire it. | ||
| if (poll.IsExpired && this.CurrentTip.Height < this.network.ConsensusOptions.Release1100ActivationHeight) |
Contributor
Author
There was a problem hiding this comment.
@quantumagi this part is important to review.
Contributor
There was a problem hiding this comment.
if (poll.IsExpired && !IsPollExpiredAt(poll, this.CurrentTip, this.network))
{
poll.IsExpired = false;
...
}
// Add this PollsRepository method which could also replace a similar method on VotingManager.
public static bool IsPollExpiredAt(Poll poll, ChainedHeader chainedHeader, Network network)
{
if (chainedHeader == null)
return false;
return Math.Max(poll.PollStartBlockData.Height + network.ConsensusOptions.PollExpiryBlocks, network.ConsensusOptions.Release1100ActivationHeight) <= chainedHeader.Height;
}
Contributor
|
LGTM. Perhaps just the one suggested change and CI must pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.