Resolve warnings found in Stratis.SmartContracts.IntegrationTests#789
Merged
quantumagi merged 6 commits intostratisproject:release/1.2.0.0from Dec 6, 2021
Merged
Conversation
Collaborator
|
Perhaps @rowandh should comment about whether the modifications to the test contracts affect the validity of the tests in any way. They probably don't, but it is good to be sure. |
Contributor
|
Both contracts appear to be unused, so we could just remove them. |
Contributor
Author
Contributor
|
Ah, missed that one, better keep the test then. I'm not sure of the behaviour if using |
rowandh
force-pushed
the
release/1.2.0.0
branch
from
1902b33 to
aee09c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/1qzu02x