Improve LastRemovalEventId determinism by adding ordering#826
Merged
quantumagi merged 3 commits intostratisproject:release/1.2.0.0from Dec 22, 2021
Merged
Conversation
fassadlr
reviewed
Dec 21, 2021
src/Stratis.Bitcoin.Features.PoA/Voting/JoinFederationRequestService.cs
Outdated
Show resolved
Hide resolved
fassadlr
reviewed
Dec 21, 2021
fassadlr
approved these changes
Dec 22, 2021
fassadlr
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Improve LastRemovalEventId determinism by adding ordering * Cleanup * Changes based on feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
OrderByDescendingto theFirstOrDefaultused to determine the last kick poll.Also, two methods are added to unify two slightly different implementations of the same logic.