Fix mining stats for non federation members#829
Merged
fassadlr merged 1 commit intorelease/1.1.2.0from Dec 24, 2021
Merged
Conversation
fassadlr
changed the title
quantumagi
reviewed
Dec 23, 2021
| if (!this.federationManager.IsFederationMember) | ||
| { | ||
| log.AppendLine("Mining information is not available for non federation members."); | ||
| log.AppendLine("It is possible that your node was kicked from the federation due to inactivity."); |
Contributor
There was a problem hiding this comment.
This can be added subject to there being a pubkey for this node. One could even check the polls in order to show a more relevant/descriptive message. E.g:
- "Your node has been voted out due to being inactive for X days and will be kicked after X blocks. Wait until then to re-join."
- "Your node has been kicked due to being inactive for X days. You can now re-join. See the join_api_url".
- "You can't participate as a federation member without a wallet."
- "You have not been voted in as a federation member. See the join_api_url".
Contributor
Author
There was a problem hiding this comment.
Thanks Gustav, will add to next PR.
quantumagi
approved these changes
Dec 23, 2021
Contributor
quantumagi
left a comment
quantumagi
left a comment
There was a problem hiding this comment.
LGTM. Just one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.