Skip to content

Include NotFound Http status code for GetBlock API call #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fassadlr merged 4 commits into from
Dec 24, 2021
Merged

Include NotFound Http status code for GetBlock API call #830

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e87deb4
Include NotFound Http status code
fassadlr Dec 23, 2021
3eb872d
Update Node Controller GetblockHeader
fassadlr Dec 23, 2021
192de87
Fix Test
fassadlr Dec 23, 2021
4e4e70e
Fix Tests
fassadlr Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Stratis.Bitcoin.Features.BlockStore/Controllers/BlockStoreController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ public IActionResult GetAddressIndexerTip()
[HttpGet]
[ProducesResponseType((int)HttpStatusCode.OK)]
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
[ProducesResponseType((int)HttpStatusCode.NotFound)]
public IActionResult GetBlock([FromQuery] SearchByHashRequest query)
{
if (!this.ModelState.IsValid)
Expand All @@ -134,14 +135,14 @@ public IActionResult GetBlock([FromQuery] SearchByHashRequest query)
ChainedHeader chainedHeader = this.chainIndexer.GetHeader(blockId);

if (chainedHeader == null)
return this.Ok("Block not found");
return this.NotFound("Block not found");

Block block = chainedHeader.Block ?? this.blockStore.GetBlock(blockId);

// In rare occasions a block that is found in the
// indexer may not have been pushed to the store yet.
if (block == null)
return this.Ok("Block not found");
return this.NotFound("Block not found");

if (!query.OutputJson)
{
Expand Down