[Cirrus] Don't cache next mining timestamp#843
Merged
quantumagi merged 3 commits intostratisproject:release/1.2.0.0from Jan 11, 2022
Merged
[Cirrus] Don't cache next mining timestamp#843quantumagi merged 3 commits intostratisproject:release/1.2.0.0from
quantumagi merged 3 commits intostratisproject:release/1.2.0.0from
Conversation
fassadlr
approved these changes
Jan 11, 2022
fassadlr
reviewed
Jan 11, 2022
| { | ||
| this.logger.LogWarning("This node is no longer a federation member!"); | ||
|
|
||
| if (myTimestamp <= (timeNow + 1)) |
Contributor
There was a problem hiding this comment.
Ohh I see that the +1 was removed here? Was that not needed?
Contributor
Author
There was a problem hiding this comment.
I don't think its necessary. I imagine the reasoning was to start the mining of the block 1 second before the timestamp. However the 1 second value seems entirely arbitrary and just introduces inaccuracies when we already allow blocks to be a second or more late. None of this affects the actual timestamp value placed on the block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.