Refactor PoAHeaderSignatureRule#890
Merged
fassadlr merged 15 commits intostratisproject:release/1.2.1.0from Feb 17, 2022
Merged
Refactor PoAHeaderSignatureRule#890fassadlr merged 15 commits intostratisproject:release/1.2.1.0from
fassadlr merged 15 commits intostratisproject:release/1.2.1.0from
Conversation
Contributor
Author
|
Will do some resync testing to ensure that there are no regression issues. |
fassadlr
approved these changes
Feb 17, 2022
Contributor
fassadlr
left a comment
fassadlr
left a comment
There was a problem hiding this comment.
Merge when testing is done. I will add my testing feedback here :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea with this PR is to leverage
GetMiningTimestampin thePoAHeaderSignatureRuleto guarantee consistency between generating and verifying timestamps.The code adapts
GetMiningTimestampto work for nodes other than just the current node. It can then be used inPoAHeaderSignatureRuleto check that the other nodes are mining at the appropriate times.