[InterFlux] Update local conversion requests state to processed#986
Merged
fassadlr merged 4 commits intorelease/1.2.3.0from May 24, 2022
Merged
[InterFlux] Update local conversion requests state to processed#986fassadlr merged 4 commits intorelease/1.2.3.0from
fassadlr merged 4 commits intorelease/1.2.3.0from
Conversation
zeptin
reviewed
May 23, 2022
src/Stratis.Bitcoin.Features.Interop/Payloads/ConversionRequestStatePayload.cs
Outdated
Show resolved
Hide resolved
zeptin
reviewed
May 24, 2022
src/Stratis.Bitcoin.Features.Interop/Payloads/ConversionRequestStatePayload.cs
Show resolved
Hide resolved
zeptin
reviewed
May 24, 2022
src/Stratis.Bitcoin.Features.Interop/Payloads/ConversionRequestStatePayload.cs
Show resolved
Hide resolved
zeptin
reviewed
May 24, 2022
zeptin
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had to remove the "auto-expiring" mechanism for nodes where the conversion request was expired if older than max-reorg blocks.
Should a node be down it is possible that that node will receive the request and expire it without it actually being processed. Those conversion requests should remain unprocessed until at least one node has set its convesion request state to processed.
The idea here is to run a periodic task that braodcasts a payload asking the nodes for the state they have on a particular conversion request. If it is processed, update our state of that request to processed.