use untyped yaml configuration as function or connector config - #233
Merged
freeznet merged 13 commits intoAug 6, 2021
Merged
Conversation
freeznet
changed the title
nlu90
approved these changes
Jul 23, 2021
Member
Author
|
@tuteng @fantapsody PTAL when you have time, thanks. |
tuteng
approved these changes
Jul 27, 2021
fantapsody
approved these changes
Jul 27, 2021
| func getUserConfig(configs map[string]string) string { | ||
| func getUserConfig(configs *v1alpha1.Config) string { | ||
| if configs == nil { | ||
| return "" |
Contributor
There was a problem hiding this comment.
"" might not be a valid json, will that be a problem?
Member
Author
There was a problem hiding this comment.
the userConfig in pulsar functions' proto FunctionDetails is defined as string, and the default value is "", so "" would be fine if there is no userConfig provided.
freeznet
force-pushed
the
freeznet/add-untyped-YAML-configuration-as-function-connector-config
branch
from
August 5, 2021 07:40
cf6cd46 to
b78380e
Compare
freeznet
deleted the
freeznet/add-untyped-YAML-configuration-as-function-connector-config
branch
August 6, 2021 00:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#231