Skip to content

upgrade to k8s.io/api/autoscaling/v2beta2 - #245

Merged
freeznet merged 29 commits into
masterfrom
freeznet/move-to-autoscaling-v2beta2
Aug 17, 2021
Merged

upgrade to k8s.io/api/autoscaling/v2beta2#245
freeznet merged 29 commits into
masterfrom
freeznet/move-to-autoscaling-v2beta2

Conversation

@freeznet

@freeznet freeznet commented Jul 30, 2021

Copy link
Copy Markdown
Member
  • upgrade autoscaling/v1 to autoscaling/v2beta2
  • add default HPA to make maxReplicas backward compatibility
  • add autoScalingMetrics and autoScalingBehavior to PodPolicy to allow user customize HorizontalPodAutoscalerSpec
  • add builtinAutoscaler to support builtin HPA rules
  • add builtin HPA rules
  • add integration test of HPA and Builtin HPA
  • add metrics-server to integration test kind cluster

@freeznet freeznet self-assigned this Jul 30, 2021
@freeznet
freeznet requested a review from nlu90 as a code owner July 30, 2021 01:01
@freeznet freeznet changed the title [WIP] move to autoscaling v2beta2 [WIP] move to k8s.io/api/autoscaling/v2beta2 Jul 30, 2021
@freeznet freeznet changed the title [WIP] move to k8s.io/api/autoscaling/v2beta2 upgrade to k8s.io/api/autoscaling/v2beta2 Aug 3, 2021
@freeznet
freeznet requested review from fantapsody and tuteng August 4, 2021 05:51
@freeznet

freeznet commented Aug 4, 2021

Copy link
Copy Markdown
Member Author

@nlu90 @fantapsody @tuteng Please help to review this PR when you have time, thanks.

@fantapsody

Copy link
Copy Markdown
Contributor

It seems we'll need user inputs to customize the autocaling metrics and behavior but I think might not be easy for users to determine a proper policy. Is it possible for us to put more best practices into the controller like what metrics and behavior should be used in general or for certain kinds of workloads (CPU/IO/Network/... intense) to make the operator easy to use?

@freeznet

freeznet commented Aug 5, 2021

Copy link
Copy Markdown
Member Author

@fantapsody thanks for the comment. We can provide some general kinds of workloads to make function-mesh more user friendly. But if we want to support the custom metrics provided by the specified Pulsar IO Connector, the harder way is still needed as well. So what do you think if we keep the current design, but provide an extra config like builtinAutoscaler and provide a bunch of pre-defined metrics and behaviours pair to let the user use?

@fantapsody

Copy link
Copy Markdown
Contributor

Sounds good.

@freeznet
freeznet force-pushed the freeznet/move-to-autoscaling-v2beta2 branch from 6dcae21 to ecd3f0a Compare August 11, 2021 01:10
@freeznet

Copy link
Copy Markdown
Member Author

@fantapsody just added builtin rules and tests, PTAL when you have time, thanks.

@freeznet
freeznet merged commit d71e754 into master Aug 17, 2021
@freeznet
freeznet deleted the freeznet/move-to-autoscaling-v2beta2 branch August 17, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants