This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[BUGFIX] Fix list topic behavior - #1005
Merged
Merged
Conversation
Demogorgon314
requested review from
BewareMyPower and
jiazhai
as code owners
December 31, 2021 04:12
BewareMyPower
approved these changes
Jan 4, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 14, 2022
Fixes #908 ### Motivation In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly. The previous fix only checked `allTopicMap` size, but we are traverse allTopicMap's value lists. So the same case might be failed. ### Modifications * Ensure all future is finished when the response
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 14, 2022
Fixes #908 ### Motivation In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly. The previous fix only checked `allTopicMap` size, but we are traverse allTopicMap's value lists. So the same case might be failed. ### Modifications * Ensure all future is finished when the response
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 9, 2022
Fixes #908 ### Motivation In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly. The previous fix only checked `allTopicMap` size, but we are traverse allTopicMap's value lists. So the same case might be failed. ### Modifications * Ensure all future is finished when the response (cherry picked from commit 4a1c51b)
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Feb 24, 2022
Fixes streamnative#908 ### Motivation In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly. The previous fix only checked `allTopicMap` size, but we are traverse allTopicMap's value lists. So the same case might be failed. ### Modifications * Ensure all future is finished when the response (cherry picked from commit 4a1c51b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #908
Motivation
In the current implementation, list topic and list offset might get the wrong response, because the authorized future is not finished yet. We need to make sure to authorize future finish correctly.
The previous fix only checked
allTopicMapsize, but we are traverse allTopicMap's value lists. So the same case might be failed.Modifications