Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Remove isMarkerMessage method in KoP MessagePublishContext #1064

Merged
BewareMyPower merged 1 commit into from
Feb 10, 2022
Merged

Remove isMarkerMessage method in KoP MessagePublishContext #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/MessagePublishContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public final class MessagePublishContext implements PublishContext {
private long sequenceId;
private long highestSequenceId;
private String producerName;
private boolean isControlBatch;

@Override
public long getSequenceId() {
Expand All @@ -56,11 +55,6 @@ public long getHighestSequenceId() {
return this.highestSequenceId;
}

@Override
public boolean isMarkerMessage() {
return this.isControlBatch;
}

private MetadataCorruptedException peekOffsetError;

@Override
Expand Down Expand Up @@ -126,7 +120,6 @@ public static MessagePublishContext get(CompletableFuture<Long> offsetFuture,
long sequenceId,
long highestSequenceId,
int numberOfMessages,
boolean isControlBatch,
long startTimeNs) {
MessagePublishContext callback = RECYCLER.get();
callback.offsetFuture = offsetFuture;
Expand All @@ -138,7 +131,6 @@ public static MessagePublishContext get(CompletableFuture<Long> offsetFuture,
callback.sequenceId = sequenceId;
callback.highestSequenceId = highestSequenceId;
callback.peekOffsetError = null;
callback.isControlBatch = isControlBatch;
return callback;
}

Expand Down Expand Up @@ -174,7 +166,6 @@ public void recycle() {
sequenceId = -1;
highestSequenceId = -1;
peekOffsetError = null;
isControlBatch = false;
recyclerHandle.recycle(this);
}
}
1 change: 0 additions & 1 deletion kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/storage/PartitionLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,6 @@ private CompletableFuture<Long> publishNormalMessage(final PersistentTopic persi
appendInfo.firstSequence(),
appendInfo.lastSequence(),
appendInfo.numMessages(),
appendInfo.isControlBatch(),
time.nanoseconds()));
return offsetFuture;
}
Expand Down