Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Fix Netty buffer / direct memory leak in MessageFetchContext - #1069

Merged
BewareMyPower merged 1 commit into
streamnative:masterfrom
lhotari:lh-fix-direct-memory-leak-in-MessageFecthContext
Feb 11, 2022
Merged

Fix Netty buffer / direct memory leak in MessageFetchContext#1069
BewareMyPower merged 1 commit into
streamnative:masterfrom
lhotari:lh-fix-direct-memory-leak-in-MessageFecthContext

Conversation

@lhotari

@lhotari lhotari commented Feb 11, 2022

Copy link
Copy Markdown
Member

- streamnative#1049 changed behavior, therefore this change is needed
@CLAassistant

CLAassistant commented Feb 11, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I am testing this change

thank you @lhotari

@eolivelli

Copy link
Copy Markdown
Contributor

I confirm that this fix resolves the memory I was investigating

@BewareMyPower
BewareMyPower merged commit bf2331a into streamnative:master Feb 11, 2022
BewareMyPower pushed a commit that referenced this pull request Feb 11, 2022
- #1049 changed behavior, therefore this change is needed

(cherry picked from commit bf2331a)
BewareMyPower pushed a commit that referenced this pull request Feb 11, 2022
- #1049 changed behavior, therefore this change is needed

(cherry picked from commit bf2331a)
BewareMyPower pushed a commit that referenced this pull request Feb 11, 2022
- #1049 changed behavior, therefore this change is needed

(cherry picked from commit bf2331a)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants