This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix the incompatibility with Pulsar 3.0.0.1-SNAPSHOT - #1759
Merged
Demogorgon314 merged 7 commits intoMar 7, 2023
Merged
Conversation
### Modifications - Upgrade the Pulsar dependency to 3.0.0.1-SNAPSHOT - Use `List<EntryFilter>` from apache/pulsar#19364 as the filters - Remove the removed APIs in `AuthorizationService` - Use `TopicType` instead of String.
coderzc
previously approved these changes
Mar 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
============================================
+ Coverage 16.04% 16.05% +0.01%
- Complexity 625 626 +1
============================================
Files 165 165
Lines 12309 12311 +2
Branches 1128 1128
============================================
+ Hits 1975 1977 +2
- Misses 10170 10171 +1
+ Partials 164 163 -1
|
Demogorgon314
approved these changes
Mar 7, 2023
BewareMyPower
added a commit
that referenced
this pull request
Jul 1, 2023
### Motivation When running `GroupMetadataManagerTest`, `testOffsetWriteAfterGroupRemoved` will be called after `testOffsetTopicNumPartitionsModify`, which changes the `offsetTopicNumPartitions` to 100 so that `consumerGroupPartitionId` will be 74 while `groupPartitionId` is 0, and then the group metadata will be sent to partition 0 while `scheduleLoadGroupAndOffsets` will read from partition 74. Since no group metadata is loaded, ### Modifications Migrate the fix in #1759 to reset the `offsetTopicNumPartitions` before and after each method.
3 tasks
Demogorgon314
pushed a commit
that referenced
this pull request
Jul 2, 2023
### Motivation When running `GroupMetadataManagerTest`, `testOffsetWriteAfterGroupRemoved` will be called after `testOffsetTopicNumPartitionsModify`, which changes the `offsetTopicNumPartitions` to 100 so that `consumerGroupPartitionId` will be 74 while `groupPartitionId` is 0, and then the group metadata will be sent to partition 0 while `scheduleLoadGroupAndOffsets` will read from partition 74. Since no group metadata is loaded, ### Modifications Migrate the fix in #1759 to reset the `offsetTopicNumPartitions` before and after each method.
BewareMyPower
pushed a commit
that referenced
this pull request
Jul 17, 2023
…1923) ### Motivation Cherry-pick s4k transaction producer state manager snapshot recovery feature. ### Modifications * Support producer state manager recovery Co-authored-by: Enrico Olivelli <enrico.olivelli@datastax.com> Co-authored-by: Michael Marshall <mmarshall@apache.org> (cherry picked from commit fcf5234) Fix conflicts caused by #1759
3 tasks
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Apr 15, 2026
…scribeConsumerGroupTest (streamnative#1760) Fixes streamnative#1759 When the Kafka admin client is configured with a small request timeout (1ms), calling `close()` could be blocked for long (5 minutes) because the RPC will always fail with timeout and retry. In this case, we only need to call `close` with a small timeout to close some resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications
List<EntryFilter>from [fix][broker] Execute per-topic entry filters with the same classloader apache/pulsar#19364 as the filtersAuthorizationServiceTopicTypeinstead of String.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)