This repository was archived by the owner on Jan 24, 2024. It is now read-only.
auto split if batch size > 4096 - #275
Closed
dockerzhang wants to merge 1 commit into
Closed
Conversation
Contributor
|
Could you add a test when a large batch was sent? |
Contributor
Author
|
@BewareMyPower I will add a UT later. |
dockerzhang
force-pushed
the
autosplit-4096
branch
from
December 29, 2020 04:00
16b8efa to
273fa9a
Compare
dockerzhang
force-pushed
the
autosplit-4096
branch
from
December 29, 2020 04:14
273fa9a to
1a861a1
Compare
Contributor
|
The tests failure could be fixed after #293 , please rebase to master after it's merged. |
dockerzhang
force-pushed
the
autosplit-4096
branch
from
December 30, 2020 02:19
1a861a1 to
28793a9
Compare
Contributor
Author
|
this PR could close if #297 will be merged. |
Contributor
|
Close this PR since #296 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #218
there is a 4096 batch size limit due to
MessageIdUtilsdesign for offset, this PR intends to auto split for size > 4096, we can use it before the offset refactor finished.