This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Add Batch support - #42
Merged
Merged
Conversation
sijie
approved these changes
Oct 4, 2019
michaeljmarshall
pushed a commit
to michaeljmarshall/kop
that referenced
this pull request
Jan 24, 2023
…Kafka 2.8.x client (streamnative#42)
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Nov 28, 2023
The wiremock dependency cannot be used with JDK 8, we need to use wiremock-jre8 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16
In KoP we would like to keep batch message. In Kafka message passed into Broker in format
Records, eachRecordscontains 1 or moreRecord. This is similar to the batched Message in Pulsar.But because we have to turn Kafka
Recordsinto Pulsar BatchedMessage to make message could both be recognized by both Pulsar and Kafka client , we have to read each Record out from Records, and turn into Pulsar Message, This may involve some overhead of un-batch/re-batch.changes: