This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix pulsar auth enable but kop not work - #60
Merged
Conversation
sijie
approved these changes
Jan 2, 2020
Member
|
@jiazhai can you please check CI result? |
sijie
added
workflow::backlog
area/protocol
type/bug
and removed
workflow::backlog
labels
Contributor
Author
|
@sijie Thanks. checked. |
michaeljmarshall
pushed a commit
to michaeljmarshall/kop
that referenced
this pull request
Apr 24, 2023
… markers and de-flaky TransactionsTest (streamnative#60)
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Jun 14, 2023
… markers and de-flaky TransactionsTest (streamnative#60)
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Jun 14, 2023
… markers and de-flaky TransactionsTest (streamnative#60)
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Jun 15, 2023
… markers and de-flaky TransactionsTest (streamnative#60)
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Jun 16, 2023
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Jun 21, 2023
… markers and de-flaky TransactionsTest (streamnative#60)
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Jun 28, 2023
… markers and de-flaky TransactionsTest (streamnative#60)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RequestHandler, we use
PersistentTopicsBase.getPartitionedTopicMetadatato get topic metadata. This need to passed inauthRole. While with pulsar auth disable, or KoP SASL auth enable, both will work OK. But with pulsar auth enabled, and KoP SASL auth disable, it may meet problem.This change changed to use
admin.topics().getPartitionedTopicMetadataAsyncto get metadata. By this way, the pulsar auth is still enable in the internal pulsar-admin/pulsar-client, and will not affect KoP.