Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Remove closed KafkaTopicConsumerManager from cache #659

Merged
BewareMyPower merged 1 commit into from
Aug 18, 2021
Merged

Remove closed KafkaTopicConsumerManager from cache #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/MessageFetchContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ public void handleFetch() {
statsLogger.getPrepareMetadataStats().registerFailedEvent(
MathUtils.elapsedNanos(startPrepareMetadataNanos), TimeUnit.NANOSECONDS);
// remove null future cache
KafkaTopicManager.removeKafkaTopicConsumerManager(KopTopic.toString(topicPartition));
KafkaTopicManager.removeKafkaTopicConsumerManager(fullTopicName);
addErrorPartitionResponse(topicPartition, Errors.NOT_LEADER_FOR_PARTITION);
return;
}
Expand Down Expand Up @@ -279,7 +279,9 @@ public void handleFetch() {
final CompletableFuture<Pair<ManagedCursor, Long>> cursorFuture = tcm.removeCursorFuture(offset);
if (cursorFuture == null) {
// tcm is closed, just return a NONE error because the channel may be still active
log.warn("[{}] KafkaTopicConsumerManager is closed", requestHandler.ctx);
log.warn("[{}] KafkaTopicConsumerManager is closed, remove TCM of {}",
requestHandler.ctx, fullTopicName);
KafkaTopicManager.removeKafkaTopicConsumerManager(fullTopicName);
addErrorPartitionResponse(topicPartition, Errors.NONE);
return;
}
Expand Down