This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Remove and close TCM according to client address - #794
Merged
BewareMyPower merged 4 commits intoOct 9, 2021
Merged
Conversation
Collaborator
Author
|
PTAL @Demogorgon314 |
BewareMyPower
added a commit
that referenced
this pull request
Oct 20, 2021
Fixes #773 ### Motivation See #773 for details. ### Modifications Add a `removeAndCloseByAddress` method to be called instead of `close` in `KafkaTopicManager#close`. Rename the current `removeAndClose` to `removeAndCloseByTopic` to differ these two methods. As for the `cursorExpireTask`, only cancel it in `KafkaProtocolHandler#close`. Add a test to verify the close of any producer doesn't affect the TCM cache, and the close of any consumer only affects the cache associated with the consumer's address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #773
Motivation
See #773 for details.
Modifications
Add a
removeAndCloseByAddressmethod to be called instead ofcloseinKafkaTopicManager#close. Rename the currentremoveAndClosetoremoveAndCloseByTopicto differ these two methods. As for thecursorExpireTask, only cancel it inKafkaProtocolHandler#close.Add a test to verify the close of any producer doesn't affect the TCM cache, and the close of any consumer only affects the cache associated with the consumer's address.