Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Issue #84: Fix NPE while enable broker publish throttling - #85

Merged
jiazhai merged 2 commits into
masterfrom
issue_84
Feb 6, 2020
Merged

Issue #84: Fix NPE while enable broker publish throttling#85
jiazhai merged 2 commits into
masterfrom
issue_84

Conversation

@jiazhai

@jiazhai jiazhai commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

Fix #84

while set

brokerPublisherThrottlingMaxByteRate

it will meet error:

08:38:34.452 [pulsar-broker-publish-rate-limiter-monitor-30-1] ERROR org.apache.bookkeeper.common.util.SafeRunnable - Unexpected throwable caught
java.lang.NullPointerException: null
        at org.apache.pulsar.broker.service.ServerCnx.enableCnxAutoRead(ServerCnx.java:1605) ~[org.apache.pulsar-pulsar-broker-2.5.0.jar:2.5.0]
        at org.apache.pulsar.broker.service.AbstractTopic.lambda$enableProducerRead$5(AbstractTopic.java:295) ~[org.apache.pulsar-pulsar-broker-2.5.0.jar:2.5.0]
        at java.util.concurrent.ConcurrentHashMap$ValuesView.forEach(ConcurrentHashMap.java:4707) ~[?:1.8.0_242]
        at org.apache.pulsar.broker.service.AbstractTopic.enableProducerRead(AbstractTopic.java:295) ~[org.apache.pulsar-pulsar-broker-2.5.0.jar:2.5.0]
        at org.apache.pulsar.broker.service.AbstractTopic.resetBrokerPublishCountAndEnableReadIfRequired(AbstractTopic.java:286) ~[org.apache.pulsar-pulsar-broker-2.5.0.jar:2.5.0]
        at org.apache.pulsar.broker.service.BrokerService.lambda$refreshBrokerPublishRate$39(BrokerService.java:1138) ~[org.apache.pulsar-pulsar-broker-2.5.0.jar:2.5.0]
        at org.apache.pulsar.broker.service.BrokerService.lambda$forEachTopic$40(BrokerService.java:1148) ~[org.apache.pulsar-pulsar-broker-2.5.0.jar:2.5.0]
        at org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap$Section.forEach(ConcurrentOpenHashMap.java:385) ~[org.apache.pulsar-pulsar-common-2.5.0.jar:2.5.0]
        at org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap.forEach(ConcurrentOpenHashMap.java:159) ~[org.apache.pulsar-pulsar-common-2.5.0.jar:2.5.0]
        at org.apache.pulsar.broker.service.BrokerService.forEachTopic(BrokerService.java:1145) ~[org.apache.pulsar-pulsar-broker-2.5.0.jar:2.5.0]
        at org.apache.pulsar.broker.service.BrokerService.refreshBrokerPublishRate(BrokerService.java:1138) ~[org.apache.pulsar-pulsar-broker-2.5.0.jar:2.5.0]
        at org.apache.pulsar.broker.service.BrokerService.lambda$setupBrokerPublishRateLimiterMonitor$9(BrokerService.java:509) ~[org.apache.pu

This is caused by the mock Producer that we registered for bundle load/unload handling.
change: provide a mock method in InternalServerCnx.

@jiazhai
jiazhai requested review from PierreZ and sijie February 6, 2020 00:05
@jiazhai jiazhai self-assigned this Feb 6, 2020
@jiazhai
jiazhai merged commit df4d3f9 into master Feb 6, 2020
@jiazhai
jiazhai deleted the issue_84 branch February 6, 2020 13:36
@jiazhai jiazhai modified the milestones: 0.0.1, 0.1.0 Feb 17, 2020
eolivelli pushed a commit to eolivelli/kop that referenced this pull request Apr 27, 2023
(cherry picked from commit 4125c258311ce208bf959764c3bee50f3ba31fe0)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NPE while enable BrokerPublishThrottling.

2 participants