This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[BUGFIX] Fix loadTxnLogTopics might crash in K8S environment - #869
Merged
BewareMyPower merged 2 commits intoNov 3, 2021
Merged
Conversation
Demogorgon314
changed the title
Demogorgon314
force-pushed
the
impl/do-not-load-TxnLog-when-handler-start
branch
from
November 3, 2021 01:57
f3d21da to
8e7cb02
Compare
Demogorgon314
marked this pull request as ready for review
November 3, 2021 03:06
BewareMyPower
approved these changes
Nov 3, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Nov 5, 2021
Fixes: #761 ### Motivation In K8S environment, load transaction topics when start KafkaProtocolHandler might crash, because to start a KoP node might depend on a successful start of another KoP node. See Related PR : #627 ### Modification The most important change is to remove the `loadTxnLogTopics ` method. Addition change is add a method to wait txnLog load in units test.
BewareMyPower
pushed a commit
that referenced
this pull request
Nov 5, 2021
Fixes: #761 ### Motivation In K8S environment, load transaction topics when start KafkaProtocolHandler might crash, because to start a KoP node might depend on a successful start of another KoP node. See Related PR : #627 ### Modification The most important change is to remove the `loadTxnLogTopics ` method. Addition change is add a method to wait txnLog load in units test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #761
Motivation
In K8S environment, load transaction topics when start KafkaProtocolHandler might crash, because to start a KoP node might depend on a successful start of another KoP node.
See Related PR : #627
Modification
The most important change is to remove the
loadTxnLogTopicsmethod.Addition change is add a method to wait txnLog load in units test.