This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Bump version to 2.8.1.26 - #950
Closed
streamnativebot wants to merge 1 commit into
Closed
Conversation
streamnativebot
requested review from
BewareMyPower and
jiazhai
as code owners
December 6, 2021 01:23
|
|
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 6, 2021
…951) Fix https://github.com/streamnative/kop/runs/4425667410?check_suite_focus=true#step:5:283 #950 ### Motivation MockZookeeper API was changed in apache/pulsar#13066, the `CreateMode` shouldn't be null. We should use MetadataStore instead of mockZooKeeper since KoP already remove all zkClient usage. ### Modifications Use MetadataStore instead of mockZooKeeper in ProducerIdManagerTest
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 6, 2021
…951) Fix https://github.com/streamnative/kop/runs/4425667410?check_suite_focus=true#step:5:283 #950 ### Motivation MockZookeeper API was changed in apache/pulsar#13066, the `CreateMode` shouldn't be null. We should use MetadataStore instead of mockZooKeeper since KoP already remove all zkClient usage. ### Modifications Use MetadataStore instead of mockZooKeeper in ProducerIdManagerTest
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 6, 2021
…951) Fix https://github.com/streamnative/kop/runs/4425667410?check_suite_focus=true#step:5:283 #950 ### Motivation MockZookeeper API was changed in apache/pulsar#13066, the `CreateMode` shouldn't be null. We should use MetadataStore instead of mockZooKeeper since KoP already remove all zkClient usage. ### Modifications Use MetadataStore instead of mockZooKeeper in ProducerIdManagerTest
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 6, 2021
Fix #950 ### Motivation apache/pulsar#13066 introduced a breaking change to the `MockZooKeeper` API and causes test failure. ### Modifications * Fix failure test * Upgrade pulsar version to 2.8.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by auto-release