Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Fix NPE problems caused by mockZooKeeper API changes when dump version to 2.8.1.26 #951

Merged
BewareMyPower merged 1 commit into from
Dec 6, 2021
Merged

Fix NPE problems caused by mockZooKeeper API changes when dump version to 2.8.1.26 #951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions ...va/io/streamnative/pulsar/handlers/kop/coordinator/transaction/ProducerIdManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
import static org.testng.AssertJUnit.fail;

import io.streamnative.pulsar.handlers.kop.KopProtocolHandlerTestBase;
import java.util.Optional;
import java.util.concurrent.TimeUnit;
import lombok.extern.slf4j.Slf4j;
import org.apache.zookeeper.data.Stat;
import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
Expand All @@ -31,6 +32,8 @@
@Slf4j
public class ProducerIdManagerTest extends KopProtocolHandlerTestBase {

private static final long DEFAULT_TEST_TIMEOUT = 20 * 1000;

@BeforeClass
@Override
protected void setup() throws Exception {
Expand All @@ -43,15 +46,13 @@ protected void cleanup() throws Exception {
super.internalCleanup();
}

@BeforeMethod
@BeforeMethod(timeOut = DEFAULT_TEST_TIMEOUT)
protected void cleanZNode() throws Exception {
Stat stat = mockZooKeeper.exists(ProducerIdManager.KOP_PID_BLOCK_ZNODE, null);
if (stat != null) {
mockZooKeeper.delete(ProducerIdManager.KOP_PID_BLOCK_ZNODE, -1);
}
pulsar.getLocalMetadataStore()
.deleteRecursive(ProducerIdManager.KOP_PID_BLOCK_ZNODE).get(10, TimeUnit.SECONDS);
}

@Test
@Test(timeOut = DEFAULT_TEST_TIMEOUT)
public void testGetProducerId() throws Exception {
ProducerIdManager manager1 = new ProducerIdManager(0, pulsar.getLocalMetadataStore());
manager1.initialize().get();
Expand All @@ -76,13 +77,14 @@ public void testGetProducerId() throws Exception {
assertEquals(pid2 + ProducerIdManager.PID_BLOCK_SIZE * 2, manager2.generateProducerId().get().longValue());
}

@Test
@Test(timeOut = DEFAULT_TEST_TIMEOUT)
public void testExceedProducerIdLimit() throws Exception {
mockZooKeeper.create(ProducerIdManager.KOP_PID_BLOCK_ZNODE, null, null, null);
mockZooKeeper.setData(ProducerIdManager.KOP_PID_BLOCK_ZNODE,
ProducerIdManager.generateProducerIdBlockJson(
new ProducerIdManager.ProducerIdBlock(
1, Long.MAX_VALUE - ProducerIdManager.PID_BLOCK_SIZE, Long.MAX_VALUE)), -1);
pulsar.getLocalMetadataStore()
.put(ProducerIdManager.KOP_PID_BLOCK_ZNODE,
ProducerIdManager.generateProducerIdBlockJson(
new ProducerIdManager.ProducerIdBlock(
1, Long.MAX_VALUE - ProducerIdManager.PID_BLOCK_SIZE, Long.MAX_VALUE)),
Optional.empty()).get(10, TimeUnit.SECONDS);

ProducerIdManager producerIdManager = new ProducerIdManager(0, pulsar.getLocalMetadataStore());
try {
Expand Down