This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Use pulsar AuthorizationService to authorize - #989
Merged
BewareMyPower merged 5 commits intoDec 29, 2021
Merged
Conversation
Demogorgon314
changed the title
Demogorgon314
changed the title
Member
Author
|
I split some of these changes to the #991, when another PR is merged, I'll mark this PR ready for review. |
Demogorgon314
force-pushed
the
fix/authorize-with-superusers
branch
from
December 28, 2021 14:55
a47599a to
3880bba
Compare
Demogorgon314
marked this pull request as ready for review
December 29, 2021 00:09
BewareMyPower
left a comment
BewareMyPower
left a comment
Contributor
There was a problem hiding this comment.
Could you add a test to verify a super user that is not configured in superUserRoles has the permission to produce or consume?
Member
Author
|
@BewareMyPower Test has been added. Please take a look again. |
BewareMyPower
approved these changes
Dec 29, 2021
Contributor
|
When I cherry-picked this PR into branch-2.8.2, a conflict happened. Please help resolve the conflict. After cherry-picking successfully and pushing to branch-2.8.2, please add the |
BewareMyPower
pushed a commit
that referenced
this pull request
Dec 29, 2021
### Motivation The current implementation of authorizing is using Pulsar's default authorization provider. For future maintenance, we better use the `AuthorizationService`. because not all users want to use Pulsar's default authorization provider. ### Modifications 1. Split CREATE, DELETE and ALTER. 2. Use `AuthorizationService` instead of Self-implementation authorization.
Demogorgon314
added a commit
that referenced
this pull request
Dec 30, 2021
### Motivation The current implementation of authorizing is using Pulsar's default authorization provider. For future maintenance, we better use the `AuthorizationService`. because not all users want to use Pulsar's default authorization provider. ### Modifications 1. Split CREATE, DELETE and ALTER. 2. Use `AuthorizationService` instead of Self-implementation authorization. (cherry picked from commit c0c1e48)
michaeljmarshall
pushed a commit
to michaeljmarshall/kop
that referenced
this pull request
Dec 13, 2022
The current implementation of authorizing is using Pulsar's default authorization provider. For future maintenance, we better use the `AuthorizationService`. because not all users want to use Pulsar's default authorization provider. 1. Split CREATE, DELETE and ALTER. 2. Use `AuthorizationService` instead of Self-implementation authorization. (cherry picked from commit c0c1e48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of authorizing is using Pulsar's default authorization provider. For future maintenance, we better use the
AuthorizationService. because not all users want to use Pulsar's default authorization provider.Modifications
AuthorizationServiceinstead of Self-implementation authorization.