[BK-SUPPORT-PART-3] Support bookkeeper bookie commands - #135
Conversation
--- Master Issue: streamnative#127 *Motivation* Support bookkeeper bookie commands in Pulsarctl *Modifications* Add bookkeeper bookie commands
|
@zymap can you rebase this pull request? |
|
@sijie sure |
|
@sijie Done. PTAL. |
| "github.com/streamnative/pulsarctl/pkg/bookkeeper/bkdata" | ||
| ) | ||
|
|
||
| type Bookie interface { |
There was a problem hiding this comment.
split the operations into two interfaces, one for cluster-wise operations, one for bookie-specific operations.
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestListArgError(t *testing.T) { |
There was a problem hiding this comment.
please include tests for normal cases.
| index FileType = "index" | ||
| ) | ||
|
|
||
| func ParseFileType(fileType string) (FileType, error) { |
| ro BookieType = "ro" | ||
| ) | ||
|
|
||
| func ParseBookieType(t string) (BookieType, error) { |
|
@sijie I don't add the test because the test needs BookKeeper HTTP service and the service seems do not start when I start a standalone. So I need to create a simple cluster to test the HTTP service. Sorry that I do not explain why the test is not added. I will add the test later soon. |
Please do this first. Let's not merge this pull request until the test framework is set up and tests are added. |
|
0.2.0 will release soon. Let's move this to 0.3.0 |
|
@sijie PTAL. Thanks |
Master Issue: #127
Motivation
Support bookkeeper bookie commands in Pulsarctl
Modifications
Add bookkeeper bookie commands
Output