Add create cmd of Pulsar Functions - #15
Merged
Merged
Conversation
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
wolfstudy
changed the title
Contributor
Author
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
sijie
requested changes
Sep 1, 2019
sijie
left a comment
sijie
left a comment
Member
There was a problem hiding this comment.
please add tests and improve the documentation.
please check how Yong did for cluster commands.
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
sijie
requested changes
Sep 2, 2019
sijie
left a comment
sijie
left a comment
Member
There was a problem hiding this comment.
Ideally we shouldn't add binary to source repo. test/functions/api-examples.jar . Can you think of improving it?
| ) | ||
|
|
||
| functionData := &pulsar.FunctionData{} | ||
|
|
Member
There was a problem hiding this comment.
Please add examples and output. See https://github.com/streamnative/pulsarctl/blob/master/pkg/ctl/cluster/update.go#L14
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Contributor
Author
In create function, i create a dummy |
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
zymap
reviewed
Sep 2, 2019
zymap
reviewed
Sep 2, 2019
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Contributor
Author
zymap
approved these changes
Sep 3, 2019
sijie
approved these changes
Sep 3, 2019
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Add create cmd of Pulsar Functions
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
Add create cmd of Pulsar Functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Add create cmd of Pulsar Functions