Add schema, offload and compaction commands of namespaces for pulsasrctl - #64
Merged
Conversation
sijie
requested changes
Sep 17, 2019
| func SetCompactionThresholdCmd(vc *cmdutils.VerbCmd) { | ||
| var desc LongDescription | ||
| desc.CommandUsedFor = "This command is used for setting compaction threshold for a namespace." | ||
| desc.CommandPermission = "This command requires super-user permissions and broker has write policies permission." |
Member
There was a problem hiding this comment.
why super-user? and what does "broker has write policies permission" mean?
Member
Author
There was a problem hiding this comment.
protected void internalSetCompactionThreshold(long newThreshold) {
validateSuperUserAccess();
validatePoliciesReadOnlyAccess();
broker has write policies permission
It will check the broker is allowed to read-write operations in the global zookeeper.
Member
There was a problem hiding this comment.
I don't think it requires super-user access. so please document this in the spreadsheet and we need to improve it.
broker has write policies permission
Okay we need to document this. Because not everyone will know what does that mean. So pleasee improve the message here.
Contributor
Contributor
|
@zymap Please rebase master code |
Member
Author
|
@wolfstudy ok |
Member
|
please rebase to master and fix CI |
Member
Author
|
@sijie PTAL. Thanks |
sijie
approved these changes
Oct 12, 2019
Member
|
Please rebase to latest master |
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
…ctl (streamnative/pulsarctl#64) Command List set-schema-validation-enforced get-schema-validation-enforced set-schema-autoupdate-strategy get-schema-autoupdate-strategy set-offload-threshold get-offload-threshold set-offload-deletion-lag get-offload-deletion-lag clear-offload-deletion-lag set-compaction-threshold get-compaction-threshold
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
…ctl (streamnative/pulsarctl#64) Command List set-schema-validation-enforced get-schema-validation-enforced set-schema-autoupdate-strategy get-schema-autoupdate-strategy set-offload-threshold get-offload-threshold set-offload-deletion-lag get-offload-deletion-lag clear-offload-deletion-lag set-compaction-threshold get-compaction-threshold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command List
set-schema-validation-enforced
get-schema-validation-enforced
set-schema-autoupdate-strategy
get-schema-autoupdate-strategy
set-offload-threshold
get-offload-threshold
set-offload-deletion-lag
get-offload-deletion-lag
clear-offload-deletion-lag
set-compaction-threshold
get-compaction-threshold