Skip to content

Add license header check for all files - #69

Merged
sijie merged 3 commits into
masterfrom
license_check
Sep 24, 2019
Merged

Add license header check for all files#69
sijie merged 3 commits into
masterfrom
license_check

Conversation

@zymap

@zymap zymap commented Sep 20, 2019

Copy link
Copy Markdown
Member

Fixes: #65

@zymap
zymap requested a review from sijie September 20, 2019 03:27
@zymap zymap self-assigned this Sep 20, 2019
@sijie sijie mentioned this pull request Sep 20, 2019
29 tasks
@wolfstudy
wolfstudy self-requested a review September 23, 2019 02:12

@wolfstudy wolfstudy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@sijie please review this pull request, thanks.

In here, we treat the check of the license header as a test file, so when we execute go test ./..., we will check all files for the correct license header.

@sijie

sijie commented Sep 24, 2019

Copy link
Copy Markdown
Member

@wolfstudy @zymap we can go with this approach for now. but is there any generic license header check tools in go?

@sijie sijie added the type/task Indicates a chore or a small item of work label Sep 24, 2019
@sijie sijie added this to the 0.0.1 milestone Sep 24, 2019
@sijie
sijie merged commit 6bad265 into master Sep 24, 2019
@sijie
sijie deleted the license_check branch September 24, 2019 06:12
@wolfstudy

Copy link
Copy Markdown
Contributor

@wolfstudy @zymap we can go with this approach for now. but is there any generic license header check tools in go?

There is currently no universal license header checker in the go community.

tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
tisonkun pushed a commit to apache/pulsar-client-go that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/task Indicates a chore or a small item of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Apache License Header and enforce license header check in CI

3 participants