Port asset filters and view options to xplat-editor from Wpf by xianbaum · Pull Request #3090 · stride3d/stride

xianbaum · 2026-03-13T16:22:51Z

PR Details

Ports the existing Wpf asset filters and view options. Most of the code is identical to the existing Wpf implementation, but some code was changed or refactored due to Avalonia's differences or new language features.

The following view options were not implemented as the required underlying asset explorer is not functionally complete, but will need to be implemented when the asset explorer is ported over.

"Assets and folders in selected folder". Asset list currently only shows assets, not folders regardless of the option selected.
View as tiles. Can't be implemented until tile view is implemented
Zoom in, zoom out. Same reason as above.
Asset tags seem unimplemented, so tag filters are implemented, but untested as well.

I have not added any unit tests yet, but I can do it if requested. Also, happy to implement any feedback.

Related Issue

#2746

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My change requires a change to the documentation.
I have added tests to cover my changes.
All new and existing tests passed.
I have built and run the editor to try this change out.

xianbaum · 2026-03-13T16:24:41Z

@dotnet-policy-service agree

xianbaum · 2026-03-13T18:47:36Z

I just realized there were some files I meant to remove that re-appeared after I tried squashing commits. ~~Fixing now.~~ Fixed!

Kryptos-FR

Thanks for the contribution. It works well. I have made a few remarks but otherwise LGTM.

Kryptos-FR · 2026-03-22T13:31:11Z

sources/presentation/Stride.Core.Presentation.Avalonia/Themes/EditorStyles.axaml

  </Styles.Resources>

+  <!-- Style for SearchComboBox -->
+  <Style Selector="sd|SearchComboBox">


It might not have been obvious but I try to keep only editor styles here that are used by the property grid. Other styles go to a different file for now, though they might all get merged together at some point.

Can you extract that style to a new file (e.g. named SearchComboBoxStyle.axaml) and reference it in App.axaml from Stride.GameStudio.Avalonia.

Kryptos-FR · 2026-03-22T13:36:41Z

sources/presentation/Stride.Core.Presentation.Avalonia/Controls/SearchComboBox.cs

+        set => SetValue(AlternativeCommandProperty, value);
+    }
+
+    /// <summary>Gets or sets the modifier keys that activate the alternative command.</summary>


nit: style preference, usually always on three lines or more. Never inlined. It makes it easier to maintain.

Note: there are a couple more occurrences of it in this file.

Added newlines for the description for this and the other occurrences.

Kryptos-FR · 2026-03-22T14:57:23Z

sources/presentation/Stride.Core.Presentation.Avalonia/Converters/BoolToOpacity.cs

@@ -0,0 +1,17 @@
+// Copyright (c) .NET Foundation and Contributors (https://dotnetfoundation.org/ & https://stride3d.net) and Silicon Studio Corp. (https://www.siliconstudio.co.jp)


For a new class/type that didn't exist before, we don't add "silicon studio" to the copyright header.

I removed "and Silicon Studio Corp. (https://www.siliconstudio.co.jp)". The other files are based on existing Wpf code, so I didn't update those.

Kryptos-FR · 2026-03-22T14:59:21Z

sources/editor/Stride.Core.Assets.Presentation/ViewModels/AssetViewModel.cs

    }
+
+    /// <summary>
+    /// Gets or sets the collection of tags associated to this asset.


"gets or sets" is incorrect here since it only has a getter. I would only keep "The collection of tags associated to this asset".

Done! I removed "Gets or sets" in other added summaries, as well.

Kryptos-FR · 2026-03-22T15:01:07Z

sources/editor/Stride.Core.Assets.Editor/ViewModels/AssetFilterViewModel.cs

+
+    /// <inheritdoc/>
+    public override int GetHashCode() =>
+        unchecked(((int)Category * 397) ^ StringComparer.OrdinalIgnoreCase.GetHashCode(Filter));


Better to use the newer Api to compute the hash by combining Category and Filter.

HashCode.Combine(Category, Filter)

xianbaum · 2026-03-23T14:01:47Z

Thanks for the contribution. It works well. I have made a few remarks but otherwise LGTM.

I appreciate the feedback. I will get on those requested changes.

Kryptos-FR · 2026-03-25T08:46:34Z

sources/editor/Stride.GameStudio.Avalonia/App.axaml

    </FluentTheme>
    <!-- FIXME xplat-editor aggregate all custom styles into a single style/theme -->
    <StyleInclude Source="avares://Stride.Core.Presentation.Avalonia/Themes/EditorStyles.axaml"/>
+    <StyleInclude Source="avares://Stride.Core.Presentation.Avalonia/Themes/SearchComboBoxStyle.axaml"/>


nit: I'm trying to keep them sorted. It should be moved between hyperlink and textlogviewer.

Alphabetized!

Kryptos-FR

LGTM. Thanks again.

VaclavElias requested a review from Kryptos-FR March 13, 2026 16:34

xianbaum force-pushed the feature/port-asset-filters branch from 2446c09 to 18c9adc Compare March 13, 2026 19:06

Port asset filters and view options to Avalonia from Wpf

6e1900b

xianbaum force-pushed the feature/port-asset-filters branch from 18c9adc to 6e1900b Compare March 13, 2026 19:35

Kryptos-FR added the area-GameStudio label Mar 22, 2026

Kryptos-FR added this to Avalonia Editor Rewrite Mar 22, 2026

Kryptos-FR linked an issue Mar 22, 2026 that may be closed by this pull request

❕🟢𝐌 Asset view filters #2746

Open

Kryptos-FR modified the milestones: Before Next Release, Editor Rewrite - Phase 1 Mar 22, 2026

Kryptos-FR self-assigned this Mar 22, 2026

Kryptos-FR requested changes Mar 22, 2026

View reviewed changes

Copyright fix and minor refactor of cross-platform asset filter code

b374288

Kryptos-FR reviewed Mar 25, 2026

View reviewed changes

Alphabetize SearchComboBoxStyle in style list

8f038f4

Kryptos-FR moved this to Review in Avalonia Editor Rewrite Mar 26, 2026

Kryptos-FR approved these changes Mar 26, 2026

View reviewed changes

		@@ -0,0 +1,17 @@
		// Copyright (c) .NET Foundation and Contributors (https://dotnetfoundation.org/ & https://stride3d.net) and Silicon Studio Corp. (https://www.siliconstudio.co.jp)

Uh oh!

Conversation

xianbaum commented Mar 13, 2026 • edited by Kryptos-FR Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

Related Issue

Types of changes

Checklist

Uh oh!

xianbaum commented Mar 13, 2026

Uh oh!

xianbaum commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kryptos-FR left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kryptos-FR Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xianbaum commented Mar 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kryptos-FR left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xianbaum commented Mar 13, 2026 •

edited by Kryptos-FR

Loading

xianbaum commented Mar 13, 2026 •

edited

Loading

Kryptos-FR Mar 22, 2026 •

edited

Loading