Skip to content

Allow to opt-out of loading shaders from original location#3105

Open
azeno wants to merge 1 commit intostride3d:masterfrom
vvvv:shader-source-file-system-opt-out
Open

Allow to opt-out of loading shaders from original location#3105
azeno wants to merge 1 commit intostride3d:masterfrom
vvvv:shader-source-file-system-opt-out

Conversation

@azeno
Copy link
Copy Markdown
Collaborator

@azeno azeno commented Mar 24, 2026

PR Details

This PR adds a property to the ShaderSourceManager which allows to opt-out of the system trying to load from the original path first.
We ran into this issue several times in the past that on build machines our app would behave differently or not run at all because it would load shaders in a different state than the app was build with.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

…ble to opt-out of loading shader source from their original location
@xen2
Copy link
Copy Markdown
Member

xen2 commented Mar 25, 2026

From top of my head, it was for either (or both) of those scenarios (dev/desktop only):

  • map to real source file (#file and #line info for debugger), otherwise any shader debugger can't trace into original source if there is no actual file
  • hot reload

Sounds good to me to have a flag for now, I will eventually get back to it with new shader system anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants