Merged
Conversation
bplunkett-stripe
force-pushed
the
bplunkett/accelerate-tests
branch
from
bb03ca9 to
782c837
Compare
bplunkett-stripe
force-pushed
the
bplunkett/accelerate-tests
branch
from
782c837 to
c63d3f5
Compare
Contributor
Author
|
Bypassing review since changes small in scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop using a test suite in the acceptance tests. This enables us to leverage
t.Parallel. Because tests ran in parallel, to maintain the same "randomly" generated outputs, I wired through a rand reader rather than relying on a global singleton. This makes tests about 50% fasterBefore:
After:
Motivation
Speed up acceptance tests.
Testing
[//]: # Describe how you tested these changes
Ran locally