This repository was archived by the owner on Feb 2, 2018. It is now read-only.
build: Update @loopback deps to latest version#11
Merged
Conversation
virkt25
commented
Oct 4, 2017
virkt25
commented
Contributor
- Update /core, /testlab, /repository
- Add /rest, /context
- Update /core, /testlab, /repository - Add /rest, /context
virkt25
requested review from
bajtos,
kjdelisle and
raymondfeng
as code owners
October 4, 2017 03:43
bajtos
approved these changes
Oct 4, 2017
bajtos
left a comment
bajtos
left a comment
Contributor
There was a problem hiding this comment.
This is not strictly needed, since the ^ operator should always install the latest alpha.
BTW why are we listing dependencies that are not used anywhere in the code, e.g. @loopback/rest? IMO we should depend only on packages that we are using, so that we don't promote a bad practice.
Other than that, the changes LGTM. No further review is necessary as far as I am concerned.
Contributor
Author
|
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.