Skip to content

add globalization#103

Merged
loay merged 1 commit intomasterfrom
globalization-loay
Jul 27, 2016
Merged

add globalization#103
loay merged 1 commit intomasterfrom
globalization-loay

Conversation

@loay
Copy link
Copy Markdown
Contributor

@loay loay commented Jul 26, 2016

@loay loay added the #review label Jul 26, 2016
@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jul 26, 2016

@superkhau @0candy
PTAL

Comment thread test-server/index.js Outdated
app.use(loopback.rest());
app.listen(3000, function() {
console.log('LoopBack test server listening on http://localhost:3000/');
console.log(g.f('LoopBack test server listening on {{http://localhost:3000/}}'));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add {{LoopBack}} for LoopBack

@0candy
Copy link
Copy Markdown

0candy commented Jul 26, 2016

You have to run slt-globalize -e again for intl/en/messages.json to get updated with the brackets change.

@loay loay force-pushed the globalization-loay branch from f9d7200 to 107c642 Compare July 26, 2016 15:41
@loay loay force-pushed the globalization-loay branch from 34f262d to 09fd067 Compare July 26, 2016 18:47
@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jul 26, 2016

@0candy Fixed

@0candy
Copy link
Copy Markdown

0candy commented Jul 27, 2016

LGTM

@loay loay merged commit 8853dbc into master Jul 27, 2016
@loay loay deleted the globalization-loay branch July 27, 2016 18:49
@loay loay removed the #review label Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants