Skip to content

Rework the implementation to use loopback-workspace 3.0 - #5

Merged
bajtos merged 3 commits into
masterfrom
feature/workspace-3.0
Jul 1, 2014
Merged

Rework the implementation to use loopback-workspace 3.0#5
bajtos merged 3 commits into
masterfrom
feature/workspace-3.0

Conversation

@bajtos

@bajtos bajtos commented Jun 30, 2014

Copy link
Copy Markdown
Member

Requires strongloop/loopback-workspace#56.

My intention is to fix the TODOs in subsequent pull requests, most of them require non-trivial changes in loopback-workspace.

/to @ritch please review

Miroslav Bajtoš added 2 commits June 30, 2014 12:35
Allow functions to be defined after they were used for the first time.
Comment thread test/app.test.js

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file not being generated?

@ritch

ritch commented Jul 1, 2014

Copy link
Copy Markdown
Member

LGTM

bajtos added a commit that referenced this pull request Jul 1, 2014
Rework the implementation to use loopback-workspace 3.0
@bajtos
bajtos merged commit 4a7ffa3 into master Jul 1, 2014
@bajtos
bajtos deleted the feature/workspace-3.0 branch July 1, 2014 14:15
Comment thread app/index.js

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to comment this or get rid of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants