Skip to content

More workspace-related changes - #6

Merged
bajtos merged 4 commits into
masterfrom
feature/workspace-round-two
Jul 2, 2014
Merged

More workspace-related changes#6
bajtos merged 4 commits into
masterfrom
feature/workspace-round-two

Conversation

@bajtos

@bajtos bajtos commented Jul 2, 2014

Copy link
Copy Markdown
Member
  • clean up TODO comments
  • app: Provide custom copyRecursive implementation
  • test/app: check *.js files are created
  • actions: validate the workspace dir in loadProject

Requires strongloop/loopback-workspace#69.

/to @ritch please review

Miroslav Bajtoš added 3 commits July 2, 2014 16:03
Use the convention // TODO({author})
Override `Workspace.copyRecursive` with yeoman's `directory` to enable
conflict detection for templated files.
@ritch

ritch commented Jul 2, 2014

Copy link
Copy Markdown
Member

LGTM

Call `Workspace.isValidDir` from `actions.loadProject` to ensure the
working directory is a valid workspace.
bajtos added a commit that referenced this pull request Jul 2, 2014
@bajtos
bajtos merged commit 5b56ce5 into master Jul 2, 2014
@bajtos
bajtos deleted the feature/workspace-round-two branch July 2, 2014 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants