Add boot script generator by superkhau · Pull Request #93 · strongloop/generator-loopback

superkhau · 2015-03-05T00:18:24Z

Add code for slc loopback:boot script command
Add unit tests

Connected to #90

Code
Code Review
Docs (https://github.com/strongloop/generator-loopback/wiki/Boot-script-generator)
Examples (https://github.com/strongloop/loopback-example-boot-scripts)

superkhau · 2015-03-05T07:45:50Z

@bajtos Review please.

/cc @raymondfeng @ritch

raymondfeng · 2015-03-05T17:04:29Z

Please fix the message

superkhau · 2015-03-05T18:18:32Z

@raymondfeng Fixed.

bajtos · 2015-03-09T16:07:38Z

Two empty lines, please keep only one of them.

bajtos · 2015-03-09T16:11:03Z

In the future, when we implement support for multiple facets (e.g. configuring loopback app in "client"), we'll need to support "/client/boot" too.

Right now, I just want to check that the current design won't make it difficult to support that?

superkhau · 2015-03-09T18:09:24Z

Yes, a simple refactor to accept a different destination dir will be possible. In that future case you describe, I'm thinking we can ask one more question (Is this a client or server side boot script? (show a list of two options client and server).

superkhau · 2015-03-09T18:09:44Z

@bajtos Added your review changes, PTAL again.

raymondfeng · 2015-03-09T22:05:43Z

Maybe better to have the following:

/* * The `app` object allows you to access a model by name (e.g. MyModel) as `app.models.MyModel` * or a data source by name (e.g. MyMongoDB) as `app.dataSources.MyDataSource` */ process.nextTick(cb); // Please remove it if you already pass `cb` to an async function

Good idea. Updating, except for the comment which is too long to fit in 80 chars. I also add the app object comments to sync.js.

- Add code for `slc loopback:boot script` command - Add unit tests

superkhau · 2015-03-09T23:15:25Z

@raymondfeng PTAL

bajtos · 2015-03-10T17:10:12Z

LGTM, please wait for @raymondfeng to approve too.

raymondfeng · 2015-03-11T17:35:08Z

LGTM

Add boot script generator

superkhau · 2015-03-11T23:07:00Z

@crandmck Merged.

superkhau added the #review label Mar 5, 2015

superkhau force-pushed the feature/boot-script-generator branch from 5aa9184 to 086c38e Compare March 5, 2015 01:31

superkhau self-assigned this Mar 5, 2015

superkhau force-pushed the feature/boot-script-generator branch from 086c38e to 4a13be7 Compare March 5, 2015 01:34

superkhau mentioned this pull request Mar 5, 2015

Add generator for boot scripts #90

Closed

raymondfeng reviewed Mar 5, 2015
View reviewed changes

Comment thread boot-script/index.js Outdated

raymondfeng Mar 5, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the message

superkhau force-pushed the feature/boot-script-generator branch from 4a13be7 to dac8b1e Compare March 5, 2015 18:17

superkhau reviewed Mar 5, 2015
View reviewed changes

Comment thread boot-script/index.js

superkhau Mar 5, 2015

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymondfeng Fixed.

superkhau assigned bajtos and unassigned superkhau Mar 6, 2015

bajtos reviewed Mar 9, 2015
View reviewed changes

bajtos assigned superkhau and unassigned bajtos Mar 9, 2015

superkhau force-pushed the feature/boot-script-generator branch from dac8b1e to 12d57b5 Compare March 9, 2015 18:05

superkhau assigned bajtos and unassigned superkhau Mar 9, 2015

superkhau assigned superkhau and unassigned bajtos Mar 9, 2015

superkhau force-pushed the feature/boot-script-generator branch from 12d57b5 to a269d8c Compare March 9, 2015 21:20

raymondfeng reviewed Mar 9, 2015
View reviewed changes

Add boot script generator

3ce547c

- Add code for `slc loopback:boot script` command - Add unit tests

superkhau force-pushed the feature/boot-script-generator branch from a269d8c to 3ce547c Compare March 9, 2015 23:15

superkhau reviewed Mar 9, 2015
View reviewed changes

Comment thread boot-script/templates/async.js

superkhau Mar 9, 2015

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymondfeng PTAL

bajtos assigned raymondfeng and unassigned superkhau Mar 10, 2015

raymondfeng assigned superkhau and unassigned raymondfeng Mar 11, 2015

superkhau added a commit that referenced this pull request Mar 11, 2015

Merge pull request #93 from strongloop/feature/boot-script-generator

4c5945a

Add boot script generator

superkhau merged commit 4c5945a into master Mar 11, 2015

superkhau removed the #review label Mar 11, 2015

superkhau deleted the feature/boot-script-generator branch March 11, 2015 23:06

Uh oh!

Conversation

superkhau commented Mar 5, 2015

Uh oh!

superkhau commented Mar 5, 2015

Uh oh!

raymondfeng Mar 5, 2015

Choose a reason for hiding this comment

Uh oh!

superkhau Mar 5, 2015

Choose a reason for hiding this comment

Uh oh!

bajtos Mar 9, 2015

Choose a reason for hiding this comment

Uh oh!

superkhau Mar 9, 2015

Choose a reason for hiding this comment

Uh oh!

bajtos commented Mar 9, 2015

Uh oh!

superkhau commented Mar 9, 2015

Uh oh!

superkhau commented Mar 9, 2015

Uh oh!

raymondfeng Mar 9, 2015

Choose a reason for hiding this comment

Uh oh!

superkhau Mar 9, 2015

Choose a reason for hiding this comment

Uh oh!

superkhau Mar 9, 2015

Choose a reason for hiding this comment

Uh oh!

bajtos commented Mar 10, 2015

Uh oh!

raymondfeng commented Mar 11, 2015

Uh oh!

superkhau commented Mar 11, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants