Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
coverage/
test/sandbox/
test/fixtures/simple-app/boot/umd.js
test/fixtures/umd-app/models/customer.js
15 changes: 15 additions & 0 deletions lib/executor.js
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,12 @@ function defineModels(app, instructions) {
if (typeof code === 'function') {
debug('Customizing model %s', name);
code(model);
// If code is a default UMD module use it
} else if (code.__esModule && code.hasOwnProperty('default')) {
if (typeof code.default === 'function') {
debug('Customizing model %s', name);
code.default(model);
}
} else {
debug('Skipping model file %s - `module.exports` is not a function',
data.sourceFile);
Expand Down Expand Up @@ -295,6 +301,15 @@ function runScripts(app, list, callback) {
path: filepath,
func: exports,
});
// If the file contains a default UMD module, load it
} else if (exports.__esModule && exports.hasOwnProperty('default')) {
if (typeof exports.default === 'function') {
debug('Exported function detected %s', filepath);
functions.push({
path: filepath,
func: exports.default,
});
}
}
} catch (err) {
g.error('Failed loading boot script: %s\n%s', filepath, err.stack);
Expand Down
16 changes: 16 additions & 0 deletions test/browser.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,22 @@ describe('browser support', function() {
});
});

it('can load UMD model code', function(done) {
var appDir = path.resolve(__dirname, './fixtures/umd-app');

browserifyTestApp(appDir, function(err, bundlePath) {
if (err) return done(err);

var app = executeBundledApp(bundlePath);

expect(Object.keys(app.models)).to.include('Customer');
expect(app.models.Customer.settings)
.to.have.property('_customized', 'Customer');

done();
});
});

it('loads mixins', function(done) {
var appDir = path.resolve(__dirname, './fixtures/browser-app');
var options = {
Expand Down
2 changes: 2 additions & 0 deletions test/executor.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ describe('executor', function() {
'barStarted',
'barFinished',
'barSyncExecuted',
'umdLoaded',
]);
done();
}, 10);
Expand All @@ -294,6 +295,7 @@ describe('executor', function() {
'barStarted',
'barFinished',
'barSyncExecuted',
'umdLoaded',
]);
done();
});
Expand Down
21 changes: 21 additions & 0 deletions test/fixtures/simple-app/boot/umd.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright IBM Corp. 2014. All Rights Reserved.
// Node module: loopback-boot
// This file is licensed under the MIT License.
// License text available at https://opensource.org/licenses/MIT
// GENERATED CODE
(function (factory) {
if (typeof module === 'object' && typeof module.exports === 'object') {
var v = factory(require, exports); if (v !== undefined) module.exports = v;
}
else if (typeof define === 'function' && define.amd) {
define(["require", "exports"], factory);
}
})(function (require, exports) {
"use strict";
function default_1(app) {
console.log('UMD Module loaded');
process.bootFlags.push('umdLoaded');
}
Object.defineProperty(exports, "__esModule", { value: true });
exports.default = default_1;
});
11 changes: 11 additions & 0 deletions test/fixtures/umd-app/app.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Copyright IBM Corp. 2015,2016. All Rights Reserved.
// Node module: loopback-boot
// This file is licensed under the MIT License.
// License text available at https://opensource.org/licenses/MIT

var loopback = require('loopback');
var boot = require('../../../');

var app = module.exports = loopback();

boot(app);
5 changes: 5 additions & 0 deletions test/fixtures/umd-app/datasources.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"db": {
"connector": "remote"
}
}
5 changes: 5 additions & 0 deletions test/fixtures/umd-app/model-config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"Customer": {
"dataSource": "db"
}
}
16 changes: 16 additions & 0 deletions test/fixtures/umd-app/models/customer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
(function (factory) {
if (typeof module === 'object' && typeof module.exports === 'object') {
var v = factory(require, exports); if (v !== undefined) module.exports = v;
}
else if (typeof define === 'function' && define.amd) {
define(["require", "exports"], factory);
}
})(function (require, exports) {
"use strict";
function default_1(Customer) {
Customer.settings._customized = 'Customer'
Customer.base.settings._customized = 'Base'
}
Object.defineProperty(exports, "__esModule", { value: true });
exports.default = default_1;
});
4 changes: 4 additions & 0 deletions test/fixtures/umd-app/models/customer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Customer",
"base": "User"
}