Skip to content

chore: upgrade deps to fix npm audit complaints #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondfeng merged 1 commit into from
Mar 26, 2019
Merged

chore: upgrade deps to fix npm audit complaints #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
sudo: false
language: node_js
node_js:
- "4"
Copy link
Copy Markdown
Member Author

@raymondfeng raymondfeng Mar 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note it won't work with Node 4.x any more. I find out loopback@3.x has node >= 6.

Copy link
Copy Markdown
Member

@bajtos bajtos Mar 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that loopback-boot supports LoopBack 2.x applications too and LB 2.x advertises node >= 4:

https://github.com/strongloop/loopback/blob/85b076c9b9a0e840036ce4380eb4e535553059fe/package.json#L38-L40

{
  "engines": {
    "node": ">=4.0.0"
  }
}

Having said that, I am ok to drop support for Node.js versions that have reached their EOL, we have done this in the past.

It's just important to be clear about our argumentation.

- "6"
- "8"

24 changes: 12 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,29 @@
"lint": "eslint ."
},
"engines": {
"node": ">=4"
"node": ">=6"
},
"license": "MIT",
"dependencies": {
"async": "~0.9.0",
"commondir": "0.0.1",
"debug": "^2.0.0",
"lodash": "^4.17.5",
"semver": "^4.1.0",
"strong-globalize": "^2.6.2",
"toposort": "^0.2.10"
"async": "^0.9.2",
"commondir": "^1.0.1",
"debug": "^3.2.6",
"lodash": "^4.17.11",
"semver": "^5.6.0",
"strong-globalize": "^4.1.3",
"toposort": "^2.0.2"
},
"devDependencies": {
"browserify": "^4.1.8",
"bluebird": "^3.1.1",
"browserify": "^16.2.3",
"chai": "^1.10.0",
"coffee-script": "^1.8.0",
"coffeeify": "^0.7.0",
"eslint": "^2.5.3",
"eslint-config-loopback": "^1.0.0",
"fs-extra": "^0.12.0",
"fs-extra": "^7.0.1",
"loopback": "^2.16.3",
"mocha": "^1.19.0",
"supertest": "^0.14.0"
"mocha": "^6.0.2",
"supertest": "^4.0.2"
}
}
2 changes: 1 addition & 1 deletion test/executor.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ describe('executor', function() {
it('skips definition of already defined LoopBack models', function() {
var builtinModel = {
name: 'User',
definition: fs.readJsonFileSync(
definition: fs.readJson(
require.resolve('loopback/common/models/user.json')
),
config: { dataSource: 'db' },
Expand Down
3 changes: 2 additions & 1 deletion test/helpers/browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ var vm = require('vm');
function createContext() {
var context = {
// required by browserify
XMLHttpRequest: function() { throw new Error('not implemented'); },
XMLHttpRequest: function() {},
clearTimeout: function() {},
FormData: function() { throw new Error('not implemented'); },

localStorage: {
Expand Down