Custom rootDir for app config - #43
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Resolves enhancement strongloop/loopback#584 |
|
@slnode ok to test |
|
@johnsoftek could you please sign the CLA? https://cla.strongloop.com/agreements/strongloop/loopback-boot |
|
CLA signed. On 3 October 2014 04:39, Miroslav Bajtoš notifications@github.com wrote:
|
|
@slnode test please |
|
@johnsoftek thanks. The patch looks good in general. Please document the new option in index.js. |
There was a problem hiding this comment.
using `get('propname')`
or perhaps
using app.get('propname')
|
Thank you for improving the documentation, I pointed few things to fix/improve in the comments above. Could you please squash all commits into a single one when you are done? I apologize for responding late. GitHub does not send any notification when a commit is added to a pull request. You have to leave a comment when the patch is ready for another round of reviews. That will send me an e-mail notification and let me know you are waiting for my input :) |
|
Done. On 9 October 2014 17:24, Miroslav Bajtoš notifications@github.com wrote:
|
|
Landed, thank you for the contribution. I have improved the formatting of the help and also added missing |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Simple option for app.boot to specify location of config.json