Skip to content

Custom rootDir for app config - #43

Closed
johnsoftek wants to merge 1 commit into
strongloop:masterfrom
johnsoftek:master
Closed

Custom rootDir for app config#43
johnsoftek wants to merge 1 commit into
strongloop:masterfrom
johnsoftek:master

Conversation

@johnsoftek

Copy link
Copy Markdown
Contributor

Simple option for app.boot to specify location of config.json

@slnode

slnode commented Sep 29, 2014

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@johnsoftek

Copy link
Copy Markdown
Contributor Author

Resolves enhancement strongloop/loopback#584

@bajtos

bajtos commented Sep 29, 2014

Copy link
Copy Markdown
Member

@slnode ok to test

@bajtos bajtos self-assigned this Sep 29, 2014
@bajtos

bajtos commented Oct 2, 2014

Copy link
Copy Markdown
Member

@johnsoftek

Copy link
Copy Markdown
Contributor Author

CLA signed.

On 3 October 2014 04:39, Miroslav Bajtoš notifications@github.com wrote:

@johnsoftek https://github.com/johnsoftek could you please sign the
CLA? https://cla.strongloop.com/agreements/strongloop/loopback-boot


Reply to this email directly or view it on GitHub
#43 (comment)
.

@bajtos

bajtos commented Oct 3, 2014

Copy link
Copy Markdown
Member

@slnode test please

@bajtos

bajtos commented Oct 3, 2014

Copy link
Copy Markdown
Member

@johnsoftek thanks. The patch looks good in general. Please document the new option in index.js.

Comment thread index.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using `get('propname')`

or perhaps

using app.get('propname')

@bajtos

bajtos commented Oct 9, 2014

Copy link
Copy Markdown
Member

Thank you for improving the documentation, I pointed few things to fix/improve in the comments above.

Could you please squash all commits into a single one when you are done?

I apologize for responding late. GitHub does not send any notification when a commit is added to a pull request. You have to leave a comment when the patch is ready for another round of reviews. That will send me an e-mail notification and let me know you are waiting for my input :)

@johnsoftek

Copy link
Copy Markdown
Contributor Author

Done.

On 9 October 2014 17:24, Miroslav Bajtoš notifications@github.com wrote:

Thank you for improving the documentation, I pointed few things to
fix/improve in the comments above.

Could you please squash all commits into a single one when you are done?

I apologize for responding late. GitHub does not send any notification
when a commit is added to a pull request. You have to leave a comment when
the patch is ready for another round of reviews. That will send me an
e-mail notification and let me know you are waiting for my input :)


Reply to this email directly or view it on GitHub
#43 (comment)
.

@bajtos

bajtos commented Oct 9, 2014

Copy link
Copy Markdown
Member

Landed, thank you for the contribution.

I have improved the formatting of the help and also added missing @property entry for the new config option - see d54e2b5.

@slnode

slnode commented Oct 9, 2014

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

This was referenced Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants