Add "booting" flag and emit "booted" event

[superkhau]

Connected to strongloop/loopback-workspace#170

[bajtos]

app.booting should be reset before calling callback(err).

[bajtos]

The implementation looks mostly good. Please add a unit-test exercising both sync and async case.

[superkhau]

@bajtos Added unit tests, reassigning to you for review.

[bajtos]

Please use .to.be.undefined() to prevent jshint warnings.

$ npm test

> loopback-boot@2.5.2 pretest /Users/bajtos/src/loopback/boot
> jscs . && jshint .

No code style errors found.
test/executor.test.js: line 57, col 33, Expected an assignment or function call and instead saw an expression.
test/executor.test.js: line 59, col 27, Expected an assignment or function call and instead saw an expression.
test/executor.test.js: line 60, col 35, Expected an assignment or function call and instead saw an expression.
test/executor.test.js: line 67, col 28, Expected an assignment or function call and instead saw an expression.
test/executor.test.js: line 71, col 27, Expected an assignment or function call and instead saw an expression.
test/executor.test.js: line 77, col 27, Expected an assignment or function call and instead saw an expression.

6 errors
npm ERR! Test failed.  See above for more details.

[superkhau]

Didn't see this because I ran mocha instead of npm test. Fixed.

[bajtos]

see my comments above.

[superkhau]

@bajtos Review again please. 196d192

[bajtos]

This assertion never fails, please remove.

If you feel a test without an assertion is confusing, then add a comment at L67 explaining that the test fails on timeout when the event is not emitted.

[superkhau]

Done.

[bajtos]

There is no test checking that app.booting is actually set to true, but I suppose I can live with that.

Please fix the comment on L67 above and squash all commits into a single one. Other than that, the patch LGTM.

[superkhau]

I wanted to add a test for app.booting = true, but I had no idea how to test it in the middle of the function execution. I'm all ears if you have a good technique to do that.

[superkhau]

@bajtos Updated with latest comments. Please review again before merge.

[bajtos]

Landed, thank you. I'll make a new npmjs release a bit later, once I have all pieces related to #86 in place.

[bajtos]

I wanted to add a test for app.booting = true, but I had no idea how to test it in the middle of the function execution. I'm all ears if you have a good technique to do that.

Add a boot script asserting on the flag.

// boot/set-app-is-booting.js
module.exports = function(app) {
  app.wasBootingInBootScript = app.booting;
}

Then run boot(app, appdir) and check that app.wasBootingInBootScript was set to true.