Skip to content

package: update devDependencies - #62

Merged
bajtos merged 1 commit into
masterfrom
run-tests-agains-loopback-2x
Oct 14, 2014
Merged

package: update devDependencies#62
bajtos merged 1 commit into
masterfrom
run-tests-agains-loopback-2x

Conversation

@bajtos

@bajtos bajtos commented Oct 14, 2014

Copy link
Copy Markdown
Member

Update devDependencies to use loopback 2.x instead of 1.x.

So far, we were running the tests against 1.x to ensure the new explorer works with the old loopback version too.

Now that loopback 2.x has been available for some time and is getting used more widely, it should be safe to stop running the tests against 1.x.

Ideally, we should run tests against all supported versions, but that IMO requires more effort that it's worth it.

/to @raymondfeng @ritch do you agree with me?
/cc @STRML

 - loopback 1.x to ^2.4.1
 - mocha ~1.20.1 to ^1.21.5
 - supertest ~0.13.0 to ~0.14.0
@bajtos

bajtos commented Oct 14, 2014

Copy link
Copy Markdown
Member Author

The only question is whether we want to drop the support for loopback 1.x completely? If not, then we need to backport pull requests like this one: strongloop/strong-remoting#113, as it is required by #61.

@ritch

ritch commented Oct 14, 2014

Copy link
Copy Markdown
Member

Agreed

@raymondfeng

Copy link
Copy Markdown
Member

The other option is to release loopback-explorer 2.x which will be only guaranteed to be compatible with loopback 2.x.

@raymondfeng

Copy link
Copy Markdown
Member

The changes LGTM.

@STRML

STRML commented Oct 14, 2014

Copy link
Copy Markdown
Member

I would agree with this. I would imagine there is a non-trivial number of people running loopback 1.x - speaking from experience, the upgrade path from 2.x was not simple.

On a related note, does anyone know if npm exposes download stats per version?

On Oct 14, 2014, at 5:21 PM, Raymond Feng notifications@github.com wrote:

The other option is to release loopback-explorer 2.x which will be only guaranteed to be compatible with loopback 2.x.


Reply to this email directly or view it on GitHub.

@bajtos

bajtos commented Oct 14, 2014

Copy link
Copy Markdown
Member Author

On a related note, does anyone know if npm exposes download stats per version?

AFAIK, it does not. Or at least it did not support that two months ago, when our colleagues were trying to get stats on how many people are using 1.x vs 2.x

bajtos added a commit that referenced this pull request Oct 14, 2014
@bajtos
bajtos merged commit d108495 into master Oct 14, 2014
@bajtos bajtos removed the #review label Oct 14, 2014
@bajtos
bajtos deleted the run-tests-agains-loopback-2x branch October 14, 2014 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants