Merged
Conversation
Contributor
Author
|
Will squash commits after review. |
| if (!exists) { | ||
| throw new Error('FileSystemProvider: Path does not exist: ' + this.root); | ||
| throw new Error(g.f('FileSystemProvider: Path does not exist: %s', this.root)); | ||
| } |
Contributor
There was a problem hiding this comment.
Should add brackets {{FileSystemProvider}} for strings that don't need to be translated.
Contributor
|
You have to run slt-globalize -e again for intl/en/messages.json to get updated with the brackets change. |
Member
|
@slnode test please |
Contributor
Author
|
@rmg,
|
Contributor
Author
|
@0candy, please review round 2 |
63 tasks
Contributor
|
Code change itself LGTM. |
richardpringle
force-pushed
the
globalization
branch
from
edde085 to
9fe951f
Compare
Contributor
Author
|
@slnode test please |
richardpringle
force-pushed
the
globalization
branch
from
9fe951f to
d1035d5
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@0candy, please review.