Skip to content

chore: improve issue and PR templates#101

Merged
nabdelgadir merged 1 commit into
masterfrom
chore/improve-issue-templates
Nov 21, 2019
Merged

chore: improve issue and PR templates#101
nabdelgadir merged 1 commit into
masterfrom
chore/improve-issue-templates

Conversation

@nabdelgadir

@nabdelgadir nabdelgadir commented Nov 16, 2019

Copy link
Copy Markdown
Contributor

Description

Improve issue and pull request templates.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@nabdelgadir

Copy link
Copy Markdown
Contributor Author

See #102 for linter fixes

@dhmlau dhmlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabdelgadir , i think we'd still want users to open bugs/features for connector specific issues in here instead of against the loopback-next repo. So maybe we can use PR https://github.com/strongloop/loopback-connector-mongodb/pull/551/files as a reference? Thanks.

@nabdelgadir

nabdelgadir commented Nov 17, 2019

Copy link
Copy Markdown
Contributor Author

@nabdelgadir , i think we'd still want users to open bugs/features for connector specific issues in here instead of against the loopback-next repo. So maybe we can use PR https://github.com/strongloop/loopback-connector-mongodb/pull/551/files as a reference? Thanks.

@dhmlau This one's using the connector specific one, but I have to update the mongodb one instead. nvm I see what you mean. I'll update this to match mongodb 👍

@nabdelgadir
nabdelgadir force-pushed the chore/improve-issue-templates branch from 1ba2922 to edd1bbb Compare November 19, 2019 16:23
@nabdelgadir
nabdelgadir force-pushed the chore/improve-issue-templates branch from edd1bbb to 4f8a372 Compare November 19, 2019 16:25
@nabdelgadir
nabdelgadir merged commit 4bfa461 into master Nov 21, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the chore/improve-issue-templates branch November 21, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants