Aggregate calls using bluebird #7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,44 @@ | ||
| 'use strict'; | ||
|
|
||
| const app = require('../server'); | ||
| const promise = require('bluebird'); | ||
|
Member
There was a problem hiding this comment. We are usually using const Promise = require('bluebird'); |
||
|
|
||
| module.exports = function(Account) { | ||
| let customerService, accountService, transactionService; | ||
|
|
||
| Account.getAccountSummary = function(accountNumber) { | ||
| let accountSummary = {}; | ||
| return findAccountSummary({id: accountNumber, accountNumber: accountNumber}) | ||
| .then(function(data) { | ||
| accountSummary = data.obj; | ||
| console.log("summary", accountSummary); | ||
| }) | ||
| .then(function() { | ||
| return findAccount({id: accountNumber, accountNumber: accountNumber}) | ||
| }) | ||
| .then(function(data) { | ||
| accountSummary.account = data.obj; | ||
| console.log("account" , data.obj); | ||
| }) | ||
| .then(function() { | ||
| return findCustomer({id: accountSummary.account.customerNumber, customerNumber: accountSummary.account.customerNumber}) | ||
| }) | ||
| .then(function(data) { | ||
| console.log(data); | ||
| accountSummary.customer = data.obj; | ||
| return accountSummary; | ||
| }); | ||
| } | ||
|
|
||
| Account.listAllAccounts = function(customerNumber, cb) { | ||
| let findAccount = accountService.getFunction('Account', 'find'); | ||
| findAccount({}, function(err, account) { | ||
| if (err) return cb(err); | ||
| cb(null, account.obj); | ||
| }); | ||
| }; | ||
|
|
||
| app.on('started', function(){ | ||
| customerService = app.dataSources.Customer; | ||
| accountService = app.dataSources.Account; | ||
| transactionService = app.dataSources.Transaction; | ||
|
|
@@ -14,36 +47,48 @@ module.exports = function(Account) { | |
| transactionService.getFunction = getFunction; | ||
| }); | ||
|
|
||
| function findTransaction(input) { | ||
| let find = transactionService.getFunction('Transaction', 'findById'); | ||
| return new Promise(function (resolve, reject) { | ||
| find(input, function(err, data) { | ||
|
Member
There was a problem hiding this comment. I think this is sort of an anti-pattern in Bluebird, use |
||
| if (err) return reject(new Error(err)); | ||
| resolve(data); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| function findAccountSummary(input) { | ||
| let find = accountService.getFunction('AccountSummary', 'findById'); | ||
| return new Promise(function (resolve, reject) { | ||
| find(input, function(err, data) { | ||
| if (err) return reject(new Error(err)); | ||
| resolve(data); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| function findAccount(input) { | ||
| let find = accountService.getFunction('Account', 'findById'); | ||
| return new Promise(function (resolve, reject) { | ||
| find(input, function(err, data) { | ||
| if (err) return reject(new Error(err)); | ||
| resolve(data); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| function findCustomer(input) { | ||
| let find = customerService.getFunction('Customer', 'findById'); | ||
| return new Promise(function (resolve, reject) { | ||
| find(input, function(err, data) { | ||
| if (err) return reject(new Error(err)); | ||
| resolve(data); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| function getFunction(model, method) { | ||
| let functionName = model + '_' + method; | ||
| return this.createModel(model, {})[functionName]; | ||
|
Member
There was a problem hiding this comment. IIUC, this is the single place where you are looking up callback-based functions. In which case this is the place where you can promisify the function before you return it back. return Promise.promisify(this.createModel(model, {})[functionName]);However, this will not work for functions that expect function getFunction(modelName, methodName) {
const functionName = modelName + '_' + methodName;
const model = this.createModel(modelName, {});
const method = Promise.promisify(model[functionName]);
return method.bind(model);
}
Member
There was a problem hiding this comment. FWIW, this should not be needed once strongloop/loopback-connector-swagger#25 is landed and released. |
||
| } | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not depend on
latest. Always use^x.y.z,"bluebird": "^3.5.0"in this particular case.If you depend on
latestand a new major version of your dependency is released, your application is very likely to break, because a new major version typically has backwards-incompatible changes.