Skip to content
This repository was archived by the owner on Apr 18, 2020. It is now read-only.

html5: Fix gulp build to create build/ directory#2

Merged
bajtos merged 1 commit into
designfrom
fix-html5-build
Apr 24, 2014
Merged

html5: Fix gulp build to create build/ directory#2
bajtos merged 1 commit into
designfrom
fix-html5-build

Conversation

@bajtos

@bajtos bajtos commented Apr 24, 2014

Copy link
Copy Markdown
Member

Fresh checkout does not contain build/ directory, therefore
fs.createWriteStream fails.

This commits adds a synchronous check + mkdir to create the directory
on the first run.

/to @ritch please review & merge at will.

Fresh checkout does not contain build/ directory, therefore
fs.createWriteStream fails.

This commits adds a synchronous check + mkdir to create the directory
on the first run.
@ritch

ritch commented Apr 24, 2014

Copy link
Copy Markdown
Member

Thanks. LGTM

On Apr 24, 2014, at 2:31 AM, Miroslav Bajtoš notifications@github.com wrote:

Fresh checkout does not contain build/ directory, therefore
fs.createWriteStream fails.

This commits adds a synchronous check + mkdir to create the directory
on the first run.

/to @ritch please review & merge at will.

You can merge this Pull Request by running

git pull https://github.com/strongloop/loopback-example-full-stack fix-html5-build
Or view, comment on, or merge it at:

#2

Commit Summary

html5: Fix gulp build to create build/ directory
File Changes

M html5/configure.js (5)
Patch Links:

https://github.com/strongloop/loopback-example-full-stack/pull/2.patch
https://github.com/strongloop/loopback-example-full-stack/pull/2.diff

Reply to this email directly or view it on GitHub.

bajtos added a commit that referenced this pull request Apr 24, 2014
html5: Fix gulp build to create build/ directory
@bajtos
bajtos merged commit 505e31b into design Apr 24, 2014
@bajtos
bajtos deleted the fix-html5-build branch April 24, 2014 14:14
jouke pushed a commit to jouke/loopback-connector-cordova-sqlite that referenced this pull request Feb 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants