phase-list: implement .zipMerge(names)#7
Merged
Merged
Conversation
The new method merges the provided list of names with the existing
phases in such way that the order of phases is preserved.
Example:
// Initial list of phases
phaseList.add(['initial', 'session', 'auth',
'routes', 'files', 'final']);
// zip-merge more phases
phaseList.zipMerge([
'initial', 'postinit', 'preauth', 'auth',
'routes', 'subapps', 'final', 'last'
]);
// print the result
console.log('Result:', phaseList.getPhaseNames());
Output:
Result: [
'initial', 'postinit', 'preauth', 'session', 'auth',
'routes', 'subapps', 'files', 'final', 'last'
]
8 tasks
Member
|
LGTM |
Member
|
This is pretty clever... I think people might get caught up on trying to re-order phases. AFAIK this will throw an error. Maybe we can create a guide for adding new phases which highlights that reordering is not possible. Overall LGTM |
bajtos
added a commit
that referenced
this pull request
Nov 13, 2014
phase-list: implement `.zipMerge(names)`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new method merges the provided list of names with the existing
phases in such way that the order of phases is preserved.
Example:
Output:
See also strongloop/loopback#786.
/to @ritch please review
/cc @raymondfeng