Revert "Fix process.stdout exiting before done"#62
Merged
davidcheung merged 1 commit intomasterfrom Nov 21, 2016
Merged
Conversation
davidcheung
force-pushed
the
revert-next-tick
branch
from
2989bac to
1f72cfc
Compare
Contributor
Author
|
@slnode test please |
This reverts commit 6a8c379. Reverting this fix because many has experienced lb-ng fails to exit and the original fix was only to help stdout getting cut off due to stdout splits long-text into chunks and process.nextTick will exit before finish outputing the long-text. Also changing include-schema test to a file instead of stdout
davidcheung
force-pushed
the
revert-next-tick
branch
from
1f72cfc to
557d0cb
Compare
Contributor
Author
bajtos
approved these changes
Nov 21, 2016
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
The revert LGTM.
However, since the stdout mode does not work reliably, we should remove it from the CLI completely. We are already working on a new semver-major release, so this is perfect timing to make that change.
This was referenced Jun 7, 2017
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect to #59 #57
This reverts commit 6a8c379.
Reverting this fix because many has experienced lb-ng fails to exit and the original fix was only to help stdout getting cut offdue to stdout splits long-text into chunks and process.nextTick
will exit before finish outputing the long-text. Also changing
include-schema test to a file instead of stdout