RFC: Initial spike on as-service architecture - #1
Closed
bajtos wants to merge 7 commits into
Closed
Conversation
added 7 commits
January 9, 2014 07:51
ngdoc comments are the Angular way of writing in-code API documentation. Tools like docular can process these comments and generate nice HTML documentation similar to docs.angularjs.org.
lb-ng-doc is a simple CLI tool that allows users to view the API documentation generated by lb-ng without the need to setup Grunt project with grunt-docular.
Member
Author
|
Replying to @seanbrookes's comment:
All of this is hopefully resolved, as we are generating a static javascript code now.
Dealers.find(
{
filter: {
where: { location: { near: '-122.2577174,49.1499898' } },
limit: 25
}
},
// etc.
There are multiple ways of creating a new User. // 1. The canonical Angular way
// Create a new User instance and call $save
var user = new User({ email: 'foo@bar.com' });
user.address = 'San Mateo';
user.$save();
// 2. An alternative way introduced by LoopBack SDK
// Call static method create
User.create(
{
email: 'foo@bar.com',
// etc.
},
// handle success & error
);See also the example in $resource docs.
Good point. I am using |
|
Looking over all the code involved, it makes enough sense to me. You're covering all the bases I'd want to see:
|
Merged
Member
Author
|
Closing in favour of #3. |
jonathan-casarrubias
referenced
this pull request
in jonathan-casarrubias/loopback-sdk-angular
May 24, 2016
fix @Inject decorator for Http
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request continues the work started in strongloop/loopback-example-access-control#5.
The most significant change is the move from a loopback plugin generating javascript on runtime to a more service-like approach, where we are providing a command-line tool for generating a static services file. This way it will be easier to integrate the generated services file into a minification & bundling workflow (e.g. via Grunt) too.
The generated file includes basic documentation comments based on remote method definitions provided by LoopBack app.
See README.md in the branch for instructions on how to use this new module.
/to @ritch @seanbrookes @Schoonology Please review the solution, whether it's easy to use, also the overall implementation design. There's no need to nit pick about implementation details, most of the code will be thrown away.
/cc @altsang