Update deprecated remoting metadata functions - #229
Merged
Conversation
Member
|
LGTM. However you should wait for @0candy's LGTM. |
Contributor
|
LGTM |
Member
|
LGTM |
davidcheung
force-pushed
the
fix-remoting-method
branch
from
July 27, 2016 20:18
29127db to
97c2630
Compare
davidcheung
pushed a commit
that referenced
this pull request
Sep 22, 2016
in strong-remoting 2.x methods `getHttpMethod()` and `getFullPath()` were used in strong-remoting 3.x we have deprecated those methods in favor of getEndPoints() this patch is so users using newer SDK can still choose to use old strong-remoting the change was introduced in /pull/229
davidcheung
pushed a commit
that referenced
this pull request
Oct 4, 2016
in strong-remoting 2.x methods `getHttpMethod()` and `getFullPath()` were used in strong-remoting 3.x we have deprecated those methods in favor of getEndPoints() this patch is so users using newer SDK can still choose to use old strong-remoting the change was introduced in /pull/229
davidcheung
pushed a commit
that referenced
this pull request
Oct 4, 2016
in strong-remoting 2.x methods `getHttpMethod()` and `getFullPath()` were used in strong-remoting 3.x we have deprecated those methods in favor of getEndPoints() this patch is so users using newer SDK can still choose to use old strong-remoting the change was introduced in /pull/229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecation warning from
getFullPath()andgetHttpMethod()See strongloop/strong-remoting#305
right now it gives deprecation warning
@0candy PTAL
/cc @Amir-61 @bajtos